Skip to content

Conversation

@scheibelp
Copy link
Collaborator

#953 broke some nightly tests that were passing before. I think this will fix four of them (lammps+rocm, remhos+rocm, remhos, lammps+openmp).

  • lammps older version was deprecated in newer spack
  • remhos refers to hypre variants that dont exist in current spack

…hypre variants that dont exist in current spack
@github-actions github-actions bot added experiment New or modified experiment application labels Sep 16, 2025
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.52%. Comparing base (9a81adb) to head (a5de7ff).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1059   +/-   ##
========================================
  Coverage    65.52%   65.52%           
========================================
  Files           44       44           
  Lines         3228     3228           
  Branches       255      255           
========================================
  Hits          2115     2115           
  Misses        1106     1106           
  Partials         7        7           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@michaelmckinsey1
Copy link
Collaborator

@scheibelp I started a pipeline for the nightly tests to double check these are resolved. There will be some expected failures which we can ignore.

@michaelmckinsey1
Copy link
Collaborator

michaelmckinsey1 commented Sep 17, 2025

Copy link
Collaborator

@michaelmckinsey1 michaelmckinsey1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing tests are unrelated

@scheibelp scheibelp added this pull request to the merge queue Sep 18, 2025
Merged via the queue into develop with commit 163d977 Sep 18, 2025
94 of 104 checks passed
@scheibelp scheibelp deleted the fix-some-nightlies branch September 18, 2025 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

application experiment New or modified experiment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants