QWS add strong/weak scaling #1192
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
experiments/qws/experiment.py
Outdated
| ) | ||
| else: | ||
| self.add_experiment_variable("n_nodes", ["1"], True) | ||
| self.add_experiment_variable("n_resources_dict", {"n_ranks": 1}, True) |
Collaborator
Author
There was a problem hiding this comment.
should this scale off ranks (1, 2, 4, 8 ranks) or nodes (1, 2, 4, 8 nodes - i.e. using all ranks)?
Collaborator
There was a problem hiding this comment.
This should scale on the basis of ranks.
pearce8
previously approved these changes
Jan 17, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1192 +/- ##
===========================================
+ Coverage 62.97% 63.09% +0.11%
===========================================
Files 45 45
Lines 3433 3433
Branches 264 264
===========================================
+ Hits 2162 2166 +4
+ Misses 1262 1258 -4
Partials 9 9 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description