Specset flavor converters #1498
Merged
+856
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyrush
reviewed
Jan 13, 2026
Member
cyrush
left a comment
cyrush
left a comment
There was a problem hiding this comment.
Look good, a few comments to address.
| const int64_accessor sbm_eids = mapitem.second.first; | ||
| const float64_accessor sbm_vals = mapitem.second.second; | ||
|
|
||
| destination[matname].set(DataType::float64(num_elems)); |
Member
There was a problem hiding this comment.
I think this should already init to 0.0, not sure we need the fill?
Can we double check?
Member
Author
There was a problem hiding this comment.
Is this guaranteed? I went down into the weeds of conduit_utils and it looks like allocation is configurable, and need not be calloc.
Member
Author
There was a problem hiding this comment.
do you know if this is for sure?
Member
Author
There was a problem hiding this comment.
I'll merge after you let me know one way or the other.
cyrush
reviewed
Jan 20, 2026
JustinPrivitera
deleted the
task/JustinPrivitera/01_07_26/specset_flavor_converters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1349