Insert axis boundary in controller, not hydro#474
Open
brbass wants to merge 1 commit intollnl:developfrom
Open
Insert axis boundary in controller, not hydro#474brbass wants to merge 1 commit intollnl:developfrom
brbass wants to merge 1 commit intollnl:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the axis boundary logic out of individual SPH and CRKSPH hydro constructors and into the SpheralController, where it is applied once during initialization. This makes the axis BC work without hydro, if needed.
ToDo :
RELEASE_NOTES.mdwith notable changes.