Fixed a logical typo in the Johnson Cook strength model#489
Open
Fixed a logical typo in the Johnson Cook strength model#489
Conversation
…use the temperature dependence to behave unphysically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a logical typo in the Johnson Cook strength model that would cause the temperature dependence to behave nonphysically.
Summary
This PR fixes a line in the Johnson Cook strength model that would cause the temperature dependence within the model to behave nonphysically.
Specifically the homologous temperature would get artificially clamped to 1 / (Tmelt - Troom) not allowing proper yielding at temperatures above the room temperature. For temperatures below room temperature updated equation results in the same homologous temperature Tstar.
Line updated from:
const auto Tstar = std::max(0.0, std::min(1.0, T(i) - mTroom)/(mTmelt - mTroom));
To:
const auto Tstar = std::max(0.0, std::min(1.0, ((T(i) - mTroom)/(mTmelt - mTroom))));
I have performed a test of my own and the yield strength now behaves more physically, without any nonphysical yield strengths emerging when a material heats up.
ToDo :
RELEASE_NOTES.mdwith notable changes.