Fix bug with Opaque-ifying identified structs with non-identified mem…

…bers
llvm · Oct 26, 2023 · dcd4d0e · dcd4d0e
1 parent 06bc20e
commit dcd4d0e
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 2 deletions.
diff --git a/lib/polygeist/Passes/ConvertToOpaquePtr.cpp b/lib/polygeist/Passes/ConvertToOpaquePtr.cpp
@@ -247,8 +247,10 @@ struct ConvertToOpaquePtrPass
         }
         for (auto ty : st.getBody()) {
           StringRef fieldKey = "";
-          if (auto fieldST = ty.dyn_cast<LLVM::LLVMStructType>())
-            fieldKey = fieldST.getName();
+          if (auto fieldST = ty.dyn_cast<LLVM::LLVMStructType>()) {
+            if (fieldST.isIdentified())
+              fieldKey = fieldST.getName();
+          }
           if (typeCache.find(fieldKey) != typeCache.end()) {
             bodyTypes.push_back(typeCache[fieldKey]);
           } else {

diff --git a/tools/cgeist/Test/Verification/opaquestr.cpp b/tools/cgeist/Test/Verification/opaquestr.cpp
@@ -0,0 +1,23 @@
+// RUN: cgeist %s %stdinclude -S | FileCheck %s
+
+struct Str {
+  int a;
+  float b;
+};
+
+struct OperandInfo {
+  OperandInfo *info;
+  struct {
+    int a;
+    float b;
+  } intfloat;
+  Str a;
+  Str *b;
+  int c;
+};
+
+void *foo(OperandInfo *info) {
+  return info;
+}
+
+// CHECK: memref<?x!llvm.struct<"opaque@polygeist@mlir@struct.OperandInfo", (memref<?x!llvm.struct<"opaque@polygeist@mlir@struct.OperandInfo">>, struct<(i32, f32)>, struct<(i32, f32)>, memref<?x!llvm.struct<(i32, f32)>>, i32)>>