add floating point trait for floating point operators for dealing with different floating point standards more programmably

Author: jiahanxie353

include/circt/Dialect/Calyx/CalyxLoweringUtils.h

@@ -424,10 +424,15 @@ class ComponentLoweringStateInterface {
     Block *body = component.getBodyBlock();
     builder.setInsertionPoint(body, body->begin());
     auto name = TLibraryOp::getOperationName().split(".").second;
-    if (std::is_same<calyx::AddFNOp, TLibraryOp>::value)
-      name = "std_addFN";
-    else if (std::is_same<calyx::MulFNOp, TLibraryOp>::value)
-      name = "std_mulFN";
+    if constexpr (TLibraryOp::template hasTrait<FloatingPoint>()) {
+      auto standard = TLibraryOp::getFloatingPointStandard();
+      if (standard == FloatingPointStandard::IEEE754) {
+        assert(name.consume_front("ieee754.") &&
+               "IEEE754 type operation's name must begin with 'ieee754'");
+        std::string modified = llvm::join_items("", "std_", name, "FN");
+        name = modified;
+      }
+    }
     return builder.create<TLibraryOp>(loc, getUniqueName(name), resTypes);
   }
 

include/circt/Dialect/Calyx/CalyxOps.h

@@ -26,6 +26,8 @@
 namespace circt {
 namespace calyx {
 
+class AddFNOp;
+class MulFNOp;
 // the goPort, donePort, resetPort and clkPort identify the attributes of the
 // go, done, reset and clk port of the circuit.
 static constexpr std::string_view goPort = "go";
@@ -67,6 +69,24 @@ class Combinational
   }
 };
 
+enum class FloatingPointStandard {
+  IEEE754,
+};
+
+/// Signals that the following operation operates on floating point values.
+template <typename ConcreteType>
+class FloatingPoint
+    : public mlir::OpTrait::TraitBase<ConcreteType, FloatingPoint> {
+public:
+  static constexpr FloatingPointStandard getFloatingPointStandard() {
+    if constexpr (std::is_same<calyx::AddFNOp, ConcreteType>::value ||
+                  std::is_same<calyx::MulFNOp, ConcreteType>::value) {
+      return FloatingPointStandard::IEEE754;
+    }
+    return FloatingPointStandard::IEEE754;
+  }
+};
+
 /// The direction of a Component or Cell port. this is similar to the
 /// implementation found in the FIRRTL dialect.
 enum Direction { Input = 0, Output = 1 };

include/circt/Dialect/Calyx/CalyxPrimitives.td

@@ -332,8 +332,15 @@ def AndLibOp  : CombinationalArithBinaryLibraryOp<"and"> {}
 def OrLibOp   : CombinationalArithBinaryLibraryOp<"or"> {}
 def XorLibOp  : CombinationalArithBinaryLibraryOp<"xor"> {}
 
-class ArithBinaryFloatingPointLibraryOp<string mnemonic> : ArithBinaryLibraryOp<mnemonic, "", [
-  SameTypeConstraint<"left", "out">]> {}
+def FloatingPoint : NativeOpTrait<"FloatingPoint"> {
+  let cppNamespace = "::circt::calyx";
+}
+
+class ArithBinaryFloatingPointLibraryOp<string mnemonic> :
+  ArithBinaryLibraryOp<mnemonic, "", [
+    FloatingPoint,
+    SameTypeConstraint<"left", "out">
+  ]> {}
 
 def AddFNOp : ArithBinaryFloatingPointLibraryOp<"ieee754.add"> {
   let results = (outs I1:$clk, I1:$reset, I1:$go, I1:$control, I1:$subOp,