Update calls to APInt constructor.

This was needed when
llvm/llvm-project@3494ee9
landed.

Similar changes were made upstream here:
https://github.com/llvm/llvm-project/pull/80309/files.

Basically, we now expect the width and value arguments to the APInt
constructor to be consistent. There is some implicit extension or
truncation depending on the signedness of the value, and now a flag to
opt into it.

With this change I've simply opted into the flag where necessary,
rather than thinking hard about how to compute the correct width given
the value.

In places where the `isSigned` flag took the default value of false, I
kept that when I had to explicitly set that flag.

There was exactly one place (CalyxHelpers.cpp), where I actually
flipped the value of `isSigned`. The comment in the code made me think
this erroneously thought the flag was "isUnsigned".

Author: mikeurbach

lib/Conversion/DCToHW/DCToHW.cpp

@@ -237,7 +237,8 @@ struct RTLBuilder {
   }
 
   Value constant(unsigned width, int64_t value, StringRef name = {}) {
-    return constant(APInt(width, value));
+    return constant(
+        APInt(width, value, /*isSigned=*/false, /*implicitTrunc=*/true));
   }
   std::pair<Value, Value> wrap(Value data, Value valid, StringRef name = {}) {
     auto wrapOp = b.create<esi::WrapValidReadyOp>(loc, data, valid);

lib/Conversion/HandshakeToHW/HandshakeToHW.cpp

@@ -484,7 +484,8 @@ struct RTLBuilder {
 
   Value constant(unsigned width, int64_t value,
                  std::optional<StringRef> name = {}) {
-    return constant(APInt(width, value));
+    return constant(
+        APInt(width, value, /*isSigned=*/false, /*implicitTrunc=*/true));
   }
   std::pair<Value, Value> wrap(Value data, Value valid,
                                std::optional<StringRef> name = {}) {

lib/Dialect/Arc/Transforms/ArcCanonicalizer.cpp

@@ -446,7 +446,8 @@ ICMPCanonicalizer::matchAndRewrite(comb::ICmpOp op,
           }
           rewriter.replaceOpWithNewOp<comb::ICmpOp>(
               op, op.getPredicate(), andOp,
-              getConstant(APInt(*optionalWidth, rhs.getZExtValue())),
+              getConstant(APInt(*optionalWidth, rhs.getZExtValue(),
+                                /*isSigned=*/false, /*implicitTrunc=*/true)),
               op.getTwoState());
           return success();
         }
@@ -464,7 +465,8 @@ ICMPCanonicalizer::matchAndRewrite(comb::ICmpOp op,
           }
           rewriter.replaceOpWithNewOp<comb::ICmpOp>(
               op, op.getPredicate(), orOp,
-              getConstant(APInt(*optionalWidth, rhs.getZExtValue())),
+              getConstant(APInt(*optionalWidth, rhs.getZExtValue(),
+                                /*isSigned=*/false, /*implicitTrunc=*/true)),
               op.getTwoState());
           return success();
         }

lib/Dialect/Calyx/Transforms/CalyxHelpers.cpp

@@ -32,8 +32,8 @@ hw::ConstantOp createConstant(Location loc, OpBuilder &builder,
                               size_t value) {
   OpBuilder::InsertionGuard g(builder);
   builder.setInsertionPointToStart(component.getBodyBlock());
-  return builder.create<hw::ConstantOp>(loc,
-                                        APInt(width, value, /*unsigned=*/true));
+  return builder.create<hw::ConstantOp>(
+      loc, APInt(width, value, /*isSigned=*/false));
 }
 
 calyx::InstanceOp createInstance(Location loc, OpBuilder &builder,

lib/Dialect/Calyx/Transforms/RemoveCombGroups.cpp

@@ -140,7 +140,7 @@ struct RemoveCombGroupsPattern : public OpRewritePattern<calyx::CombGroupOp> {
 
     rewriter.setInsertionPointToStart(group.getBodyBlock());
     auto oneConstant = rewriter.create<hw::ConstantOp>(
-        group.getLoc(), APInt(1, 1, /*isSigned=*/true));
+        group.getLoc(), APInt(1, 1, /*isSigned=*/true, /*implicitTrunc=*/true));
 
     // Maintain the set of cell results which have already been assigned to
     // its register within this group.

lib/Dialect/FIRRTL/FIRRTLUtils.cpp

@@ -188,7 +188,8 @@ IntegerAttr circt::firrtl::getIntZerosAttr(Type type) {
 /// type. This handles both the known width and unknown width case.
 IntegerAttr circt::firrtl::getIntOnesAttr(Type type) {
   int32_t width = abs(type_cast<IntType>(type).getWidthOrSentinel());
-  return getIntAttr(type, APInt(width, -1));
+  return getIntAttr(
+      type, APInt(width, -1, /*isSigned=*/false, /*implicitTrunc=*/true));
 }
 
 /// Return the single assignment to a Property value. It is assumed that the

lib/Dialect/HW/HWOps.cpp

@@ -309,7 +309,9 @@ void ConstantOp::build(OpBuilder &builder, OperationState &result,
 void ConstantOp::build(OpBuilder &builder, OperationState &result, Type type,
                        int64_t value) {
   auto numBits = cast<IntegerType>(type).getWidth();
-  build(builder, result, APInt(numBits, (uint64_t)value, /*isSigned=*/true));
+  build(builder, result,
+        APInt(numBits, (uint64_t)value, /*isSigned=*/true,
+              /*implicitTrunc=*/true));
 }
 
 void ConstantOp::getAsmResultNames(

tools/handshake-runner/Simulation.cpp

@@ -89,13 +89,13 @@ Any readValueWithType(mlir::Type type, std::stringstream &arg) {
     int64_t x;
     arg >> x;
     int64_t width = INDEX_WIDTH;
-    APInt aparg(width, x);
+    APInt aparg(width, x, /*isSigned=*/false, /*implicitTrunc=*/true);
     return aparg;
   } else if (isa<mlir::IntegerType>(type)) {
     int64_t x;
     arg >> x;
     int64_t width = type.getIntOrFloatBitWidth();
-    APInt aparg(width, x);
+    APInt aparg(width, x, /*isSigned=*/false, /*implicitTrunc=*/true);
     return aparg;
   } else if (type.isF32()) {
     float x;