Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scalar overload name constructed by ReplaceWithVeclib.cpp #111095

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Commits on Oct 4, 2024

  1. Fix scalar overload name constructed by ReplaceWithVeclib.cpp

    ReplaceWithVeclib.cpp would construct overload name using all the arguments in the intrinsic, but overloads should only be constructed from arguments for which isVectorIntrinsicWithOverloadTypeAtArg returns true, including the return (-1).
    
    Fixes llvm#111093
    tex3d committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    8227c91 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Configuration menu
    Copy the full SHA
    f0557de View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2c70285 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Rework logic to preserve "scalar" operand/return type, even if vector

    If isVectorIntrinsicWithScalarOpAtArg() returns true for an argument or return, we should not attempt to modify the type or use the element count, even if it is a vector.  This allows the op to be identified as something that doesn't vectorize/scalarize with the width of the intrinsic, but remains the same, even if it is a vector argument.
    
    Initial ElementCount will only be the return element count if it's a vector and isVectorIntrinsicWithScalarOpAtArg returns false.
    
    This also returns the control flow in the loop to be closer to the original.
    
    Remove inconsistent comment about VFABI return type assumption, since we have the accessors that tell us how to handle it for the operation.
    
    Fix formatting.
    tex3d committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    5e92c3d View commit details
    Browse the repository at this point in the history
  2. fix formatting

    tex3d committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    9adc046 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6a07812 View commit details
    Browse the repository at this point in the history