[clang-tidy][NFC] Enable bugprone-unchecked-optional-access in clang-tidy config and fix warnings
#170004
+73
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…idyDiagnosticConsumer" This reverts commit 7f6239f.
zeyi2
commented
Nov 29, 2025
| } | ||
|
|
||
| void ClangTidyProfiling::storeProfileData(llvm::TimerGroup &TG) { | ||
| assert(Storage && "We should have a filename."); |
Member
Author
There was a problem hiding this comment.
Will fix the removal of this assert soon.
zeyi2
commented
Nov 29, 2025
Member
Author
There was a problem hiding this comment.
This modification causes 5 cases to fail:
Clang Tools :: clang-tidy/checkers/bugprone/dynamic-static-initializers.hpp
Clang Tools :: clang-tidy/checkers/bugprone/suspicious-include.cpp
Clang Tools :: clang-tidy/checkers/misc/use-anonymous-namespace.cpp
Clang Tools :: clang-tidy/checkers/misc/use-internal-linkage-func.cpp
Extra Tools Unit Tests :: clang-tidy/./ClangTidyTests/LLVMHeaderGuardCheckTest/FixHeaderGuards
I suspect that there may be some lifetime issues (and also the use of std::vector/string, will try to fix them soon)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is currently work in progress.
Currently
ClangTidyDiagnosticConsumeris not fixed.Closes #156151