Skip to content

Commit

Permalink
Revert "Do not create build requests for workers if offline longer th…
Browse files Browse the repository at this point in the history
…an 30 minutes."

This reverts commit 618344c and
fab27e2.

Otherwise we observe the failure in presubmit:
   $ cd buildbot/osuosl/master && BUILDBOT_TEST=1 buildbot checkconfig
   Configuration Errors:
   Unknown BuildmasterConfig key ignoreOfflineWorkersTimeout

FWICT, ignoreOfflineWorkersTimeout is not documented anywhere. It has been
implied that LLVM's buildbot has downstream patches. I could not find where
these were published, and the issue is now blocking me from further updates to
CI. Rip everything out for now.

>> LLVM's buildbot seems to be deploying a forked version

Link: 618344c
  • Loading branch information
nickdesaulniers committed Dec 3, 2024
1 parent fab27e2 commit 0c38d55
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions buildbot/osuosl/master/master.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,6 @@ c['workers'] = config.workers.get_all()

c['protocols'] = {'pb': {'port': "tcp:9990:interface=127.0.0.1" if test_mode else 9990}}

if not test_mode: # Config key only supported on downstream buildbot fork.
c['ignoreOfflineWorkersTimeout'] = 30 # minutes.

####### CHANGESOURCES

##from buildbot.changes.pb import PBChangeSource
Expand Down

0 comments on commit 0c38d55

Please sign in to comment.