[Offload] Adds buildbot for CMake cache file #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhuber6
reviewed
Dec 17, 2024
| # Use Ninja as the generator. | ||
| # The other important settings alrady come from the CMake CMake | ||
| # cache file inside LLVM | ||
| cmake_args = ["-GNinja", "-C %s" % cmake_cache_file] |
There was a problem hiding this comment.
Can we not just put this in the extra Cmake args?
There was a problem hiding this comment.
I'm not sure whether they exist on the AnnotatedBuilder that this is using.
To be clear, this is not using the OpenMPBuilder buildbot that we have based the other buildbots on.
jhuber6
approved these changes
Dec 17, 2024
jplehr
force-pushed
the
feat/amdgpu-cmake-bot
branch
2 times, most recently
from
d05934e to
43c9464
Compare
The buildbot uses the offload/cmake/cache/AMDGPUBot.cmake file to create the build config. It uses an annotated builder for that and only performs the build step as most of the post-commit issues are build problems and not test errors.
jplehr
force-pushed
the
feat/amdgpu-cmake-bot
branch
from
43c9464 to
1e8322e
Compare
|
I removed the unrelated new-line and blank changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The buildbot uses the offload/cmake/cache/AMDGPUBot.cmake file to create the build config. It uses an annotated builder for that and only performs the build step as most of the post-commit issues are build problems and not test errors.