Skip to content

[BOLT] Add AArch64 worker and builder #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025

Conversation

paschalis-mpeis
Copy link
Member

No description provided.

@paschalis-mpeis
Copy link
Member Author

Hey folks,

This PR is part of introducing an AArch64 BOLT buildbot.

I have a couple of questions to @gkistanova:

(1) The worker name bolt-worker-aarch64 would recycled after PR #459 is merged. Or should we use a different name?

Specifically, could reusing Meta's former AArch64 buildbot name cause issues in the staging/master buildbot database?

(2) In the docs, the Steps To Add Builder To LLVM Buildbot section advices buildbot version 2.8.4, while Testing a Builder Config Locally version 3.11.7. Is the latter specific to local config testing, or should we pump the version on the guide?

Thanks in advance,
Paschalis

@paschalis-mpeis paschalis-mpeis marked this pull request as ready for review June 10, 2025 16:11
@paschalis-mpeis paschalis-mpeis requested review from gkistanova, lukel97, vvereschaka and aaupov and removed request for gkistanova and lukel97 June 10, 2025 16:11
@paschalis-mpeis paschalis-mpeis force-pushed the users/paschalis-mpeis/boltbuilder-marks-build-skipped branch from 653cf9c to 05f5a8b Compare June 16, 2025 09:18
@paschalis-mpeis paschalis-mpeis force-pushed the users/paschalis-mpeis/add-aarch64-buildbot branch from d7c36d6 to 5f7fcb6 Compare June 16, 2025 09:23
Copy link
Contributor

@aaupov aaupov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for setting up an official BOLT AArch64 testing!

@paschalis-mpeis paschalis-mpeis force-pushed the users/paschalis-mpeis/boltbuilder-marks-build-skipped branch from 05f5a8b to 04d1f0c Compare June 18, 2025 10:04
@paschalis-mpeis paschalis-mpeis force-pushed the users/paschalis-mpeis/add-aarch64-buildbot branch 2 times, most recently from db85fc1 to a0f6fa2 Compare June 20, 2025 17:15
@paschalis-mpeis paschalis-mpeis changed the base branch from users/paschalis-mpeis/boltbuilder-marks-build-skipped to users/paschalis-mpeis/boltbuilder-improve-cleanup June 20, 2025 17:15
@paschalis-mpeis
Copy link
Member Author

Forced pushed and rebased on top of #480, which does some cleanup and a few improvements in some edge case handling. No code changes in this rebase.

@vvereschaka
Copy link
Contributor

Hi @paschalis-mpeis ,

just curious, is there any plans to launch the cross builders for BOLT, such as Linux/Win x86_64 => Linux/Aarch64 or similar?

Thanks,

@paschalis-mpeis paschalis-mpeis force-pushed the users/paschalis-mpeis/boltbuilder-improve-cleanup branch from 3369ad4 to 1160096 Compare June 23, 2025 08:28
@paschalis-mpeis paschalis-mpeis force-pushed the users/paschalis-mpeis/add-aarch64-buildbot branch from a0f6fa2 to e4f85f1 Compare June 23, 2025 08:33
@paschalis-mpeis
Copy link
Member Author

Hi @vvereschaka,

Thanks for your interest! I captured the scope of this on Discourse:

This buildbot focuses on validating the BOLT AArch64 backend on Linux (Ubuntu 24). That said, it also builds a few additional targets though coverage for those is limited. I'm not sure if this fully answers your question. Let me know if otherwise.

BOLT will also be shipped as part of our ATfL toolchain, and we intend to run nightly tests on the supported Linux platforms (cc: @pawosm-arm).

Copy link
Contributor

@gkistanova gkistanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@paschalis-mpeis paschalis-mpeis force-pushed the users/paschalis-mpeis/boltbuilder-improve-cleanup branch from 60f68b2 to e5a730a Compare June 26, 2025 09:15
@paschalis-mpeis paschalis-mpeis changed the base branch from users/paschalis-mpeis/boltbuilder-improve-cleanup to main June 26, 2025 09:19
@paschalis-mpeis paschalis-mpeis force-pushed the users/paschalis-mpeis/add-aarch64-buildbot branch from e4f85f1 to 3cb4810 Compare June 26, 2025 09:22
@paschalis-mpeis paschalis-mpeis merged commit 2444fdd into main Jun 26, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants