Skip to content

Update ALL ${ } usages across the file + feature requests 14, 25 & 26#27

Open
DoktorShift wants to merge 11 commits intolnbits:mainfrom
DoktorShift:working_on_fr
Open

Update ALL ${ } usages across the file + feature requests 14, 25 & 26#27
DoktorShift wants to merge 11 commits intolnbits:mainfrom
DoktorShift:working_on_fr

Conversation

@DoktorShift
Copy link

  1. Did a refactor to update ALL ${ } usages across the file to use v-text and remove delimiters entirely.

  2. [Bug] Should display all connections by default #14 Default select the first Wallet when opening the extension

Bildschirmfoto 2026-01-14 um 18 00 54
  1. Feature: Include lightning address in NWC connection string if the wallet has a receive paylink #25 Added lud16 to nwc string and table
Bildschirmfoto 2026-01-14 um 18 00 03 Bildschirmfoto 2026-01-14 um 18 00 14 Bildschirmfoto 2026-01-14 um 17 59 15
  1. Feature: Include comment/payment note for payments received #26 added comment/memo/description

if a payer sends an LNURL comment (like "Thanks for the coffee!"), it will appear as the description in list_transactions. If no comment exists, it falls back to the payment memo, then to the BOLT11 invoice description.
instead of taking the name of receive wallet.

Copy link

@talvasconcelos talvasconcelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still some linting issues

views_api.py Outdated

try:
# Import lnurlp crud - may not be installed
from lnbits.extensions.lnurlp.crud import get_pay_links # type: ignore

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import at the top of the file

inside the try/except

return if get_pay_links is undefined, on the endpoint!

@DoktorShift
Copy link
Author

#14

Updated behaviour for mentioned Issue.

  1. New Selector "All Wallets". Shows on default all wallets with all connections. Wallet Name Clickable with forward.
Bildschirmfoto 2026-02-03 um 17 37 19
  1. Wallet Selector shows small pill with amount of connections
Bildschirmfoto 2026-02-03 um 17 42 38
  1. Empty Screen with CTA for creating a connection
  2. Info Modal updated with less confusing information
Bildschirmfoto 2026-02-03 um 17 44 50

@blackcoffeexbt
Copy link

A few points from me:
Could you change text strings:

  • "Connect only with app you trust!" to "Connect only an with app that you trust!"
  • "Limit the spendable amount" to "Set a spending limit"
  • "Authorize the app to" to "Authorize the connected app to"

What is the "lightning address" field for?
Could you add a line below the lightning address field explaining its purpose?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants