Update ALL ${ } usages across the file + feature requests 14, 25 & 26#27
Open
DoktorShift wants to merge 11 commits intolnbits:mainfrom
Open
Update ALL ${ } usages across the file + feature requests 14, 25 & 26#27DoktorShift wants to merge 11 commits intolnbits:mainfrom
DoktorShift wants to merge 11 commits intolnbits:mainfrom
Conversation
talvasconcelos
requested changes
Jan 23, 2026
views_api.py
Outdated
|
|
||
| try: | ||
| # Import lnurlp crud - may not be installed | ||
| from lnbits.extensions.lnurlp.crud import get_pay_links # type: ignore |
There was a problem hiding this comment.
import at the top of the file
inside the try/except
return if get_pay_links is undefined, on the endpoint!
Author
|
A few points from me:
What is the "lightning address" field for? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Did a refactor to update ALL ${ } usages across the file to use v-text and remove delimiters entirely.
[Bug] Should display all connections by default #14 Default select the first Wallet when opening the extension
if a payer sends an LNURL comment (like "Thanks for the coffee!"), it will appear as the description in list_transactions. If no comment exists, it falls back to the payment memo, then to the BOLT11 invoice description.
instead of taking the name of receive wallet.