Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add caribbean currencies #17

Closed
wants to merge 3 commits into from
Closed

add caribbean currencies #17

wants to merge 3 commits into from

Conversation

islandbitcoin
Copy link

No description provided.

@islandbitcoin islandbitcoin requested a review from brh28 April 1, 2024 21:59
@islandbitcoin islandbitcoin self-assigned this Apr 1, 2024
Copy link
Collaborator

@brh28 brh28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, this change only adds price data to the UI? It does not allow users to denominate their account in another currency?

Also, do you know if this backfills with historical price data for each of these currencies? or does this just allow querying for current price data?

@islandbitcoin
Copy link
Author

If I understand correctly, this change only adds price data to the UI? It does not allow users to denominate their account in another currency?

Also, do you know if this backfills with historical price data for each of these currencies? or does this just allow querying for current price data?

correct. its just a display currency. Their wallets will always be denominated in USD or BTC.

It does not backfill for historical price, this is only for real-time conversion on the Home Screen. The historical chart is in USD.

@islandbitcoin
Copy link
Author

I don't think I have the format correct for realtime.config

@islandbitcoin islandbitcoin marked this pull request as draft April 11, 2024 14:43
@islandbitcoin islandbitcoin linked an issue Apr 11, 2024 that may be closed by this pull request
@brh28
Copy link
Collaborator

brh28 commented Apr 17, 2024

What documentation have you seen for this? How did you know to update Values.realtime.config with the values provided?

@brh28
Copy link
Collaborator

brh28 commented Apr 17, 2024

Pod is failing in the dev environment with:

ConfigError: Invalid yaml configuration
    at Object.<anonymous> (/app/config/yaml.js:53:11)
    at Module._compile (node:internal/modules/cjs/loader:1241:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1295:10)
    at Module.load (node:internal/modules/cjs/loader:1091:32)
    at Module._load (node:internal/modules/cjs/loader:938:12)
    at Module.require (node:internal/modules/cjs/loader:1115:19)
    at require (node:internal/modules/helpers:130:18)
    at Object.<anonymous> (/app/config/index.js:19:14)
    at Module._compile (node:internal/modules/cjs/loader:1241:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1295:10) {
  data: [
    {
      instancePath: '',
      schemaPath: '#/additionalProperties',
      keyword: 'additionalProperties',
      params: { additionalProperty: '0' },
      message: 'must NOT have additional properties'
    }
  ]
}

@brh28
Copy link
Collaborator

brh28 commented Apr 17, 2024

What documentation have you seen for this? How did you know to update Values.realtime.config with the values provided?

From Arvin at Galoy:

Yup that's a price server thing
https://t.co/oajegdSByI
From github.com
This is the relevant config here in the repo
https://t.co/Pi4QPw16Nz
From github.com
And I think we inject all our currencies via an override of this entry in charts
❤️

thx man

@brh28 brh28 closed this Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add caribbean currencies
2 participants