Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preloading clean #1810

Merged
merged 56 commits into from
Sep 16, 2024
Merged

Preloading clean #1810

merged 56 commits into from
Sep 16, 2024

Conversation

treelin611
Copy link
Collaborator

Motivate of the pull request

  • To preload unique blocks from the provided XML file into the device_rr_gsb class.

Describe the technical details

What is currently done?

  • Added two commands: read_unique_blocks and write_unique_blocks.
  • Added one attribute to the build_fabric command: --preload_unique_blocks. When preloading unique blocks from the user-provided XML file, this option should be enabled. This ensures that when build_fabric is called, it will skip the default method used to build unique blocks.

Note

  • As gsb is not preloaded yet, we will build gsb using the preloaded sb, cbx, and cby when read_unique_blocks is called.

@tangxifan
Copy link
Collaborator

@treelin611 Please clean up the CI errors.

tangxifan
tangxifan requested changes Aug 28, 2024
View reviewed changes
openfpga/src/base/openfpga_build_fabric_template.h Show resolved Hide resolved
openfpga/src/base/openfpga_build_fabric_template.h Show resolved Hide resolved
openfpga/src/base/openfpga_setup_command_template.h Outdated Show resolved Hide resolved
openfpga/src/base/openfpga_setup_command_template.h Outdated Show resolved Hide resolved
openfpga/src/base/openfpga_setup_command_template.h Outdated Show resolved Hide resolved
openfpga/src/fabric/read_write_xml_unique_blocks.h Outdated Show resolved Hide resolved
openfpga/src/fabric/read_write_xml_unique_blocks.h Outdated Show resolved Hide resolved
openfpga/src/fabric/read_write_xml_unique_blocks.h Outdated Show resolved Hide resolved
openfpga_flow/tasks/basic_tests/preload_unique_blocks/read_unique_blocks/config/task.conf Show resolved Hide resolved
openfpga_flow/tasks/basic_tests/preload_unique_blocks/write_unique_blocks/design_variables.yml Outdated Show resolved Hide resolved
tangxifan
tangxifan requested changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@tangxifan tangxifan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@treelin611 Good work. Final comments. Also we need a follow-up PR to support binary format for the file.

openfpga/src/annotation/device_rr_gsb.h Outdated Show resolved Hide resolved
openfpga/src/annotation/device_rr_gsb.h Outdated Show resolved Hide resolved
openfpga/src/base/openfpga_setup_command_template.h Show resolved Hide resolved
openfpga/src/annotation/device_rr_gsb.h Outdated Show resolved Hide resolved
docs/source/manual/file_formats/unique_blocks.rst Show resolved Hide resolved
openfpga/src/annotation/read_xml_unique_blocks.cpp Outdated Show resolved Hide resolved
openfpga/src/annotation/device_rr_gsb.cpp Outdated Show resolved Hide resolved
openfpga/src/base/openfpga_build_fabric_template.h Outdated Show resolved Hide resolved
openfpga_flow/openfpga_shell_scripts/read_unique_blocks_full_flow_example_script.openfpga Show resolved Hide resolved
openfpga_flow/openfpga_shell_scripts/write_unique_blocks_full_flow_example_script.openfpga Show resolved Hide resolved
tangxifan
tangxifan previously approved these changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@tangxifan tangxifan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@treelin611 Good work. Please resolve the merging conflicts. Then I will merge this PR. Also please document the TODO on this PR.

  • Support binary file format as an alternative to the XML

@treelin611
Copy link
Collaborator Author

treelin611 commented Sep 14, 2024 •
edited
Loading

@treelin611 Good work. Please resolve the merging conflicts. Then I will merge this PR. Also please document the TODO on this PR.

  • Support binary file format as an alternative to the XML

Noted! An issue will be created for this todo

@treelin611 treelin611 closed this Sep 14, 2024
@treelin611 treelin611 reopened this Sep 14, 2024
@tangxifan tangxifan merged commit 03b06ba into master Sep 16, 2024
45 of 64 checks passed
@tangxifan tangxifan deleted the preloading_clean branch September 16, 2024 19:13
@tangxifan tangxifan mentioned this pull request Sep 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangxifan tangxifan tangxifan approved these changes

@Tulong4Dev Tulong4Dev Tulong4Dev left review comments

Assignees
No one assigned
Labels
documentation flow-scripts openfpga-tools tests VPR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@treelin611 @tangxifan @Tulong4Dev