Add script to write the serial print into a log file. #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augustofg
requested changes
Feb 5, 2025
gustavosr8
force-pushed
the
log-serial
branch
3 times, most recently
from
bb812c2 to
a3e00cb
Compare
gustavosr8
force-pushed
the
log-serial
branch
from
a3e00cb to
77cbdae
Compare
ericonr
requested changes
Feb 17, 2025
| Description=Serial Logger Service | ||
|
|
||
| [Service] | ||
| ExecStart=/usr/local/bin/log-serial.py /var/log/openmmc-serial.log /dev/serial/by-id/%i |
There was a problem hiding this comment.
The log file should also be parametrized with %i
There was a problem hiding this comment.
Also, we should add usage of disable-jtag somewhere, right? Or since it doesn't work, should we avoid merging it for now?
There was a problem hiding this comment.
Hmm, IDK how to deal with this situation... disable-jtag does what we expect, but the behavior isn't what we expect due to a hardware bug. Since the problem is not in the software layer, should we also merge it and include its usage since it is implemented correctly, or should we avoid it since the final behavior will not be the expected one?
|
moved to lnls-dig/bpm-app#36 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.