fix(assign-rfc-reviewer):Avoid re-requesting reviews#10
Draft
fix(assign-rfc-reviewer):Avoid re-requesting reviews#10
Conversation
When this action re-requests review from a team, it's PR Review status is set to "Pending", even if it was "Commented"/"Approved"/"Requested Changes" before. The PR Review status shouldn't be automatically changed. Also, there can be false-positive cases for the keywords search. Now, when a false-positive is detected by a team, they can just make a "Comment Review" in the PR. By doing this, the slack bot "Github Scheduled Reminders" shouldn't notify the team about these false-positives.
Author
|
Endpoint Another alternative could be to get the PR reviews from https://docs.github.com/rest/pulls/reviews#list-reviews-for-a-pull-request and look up the team for each member ( https://docs.github.com/pt/rest/teams/members ). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When this action re-requests review from a team, it's PR Review status is set to "Pending", even if it was "Commented"/"Approved"/"Requested Changes" before.
The PR Review status shouldn't be automatically changed.
Also, there can be false-positive cases for the keywords search.
Now, when a false-positive is detected by a team, they can just make a "Comment Review" in the PR.
By doing this, the slack bot "Github Scheduled Reminders" shouldn't notify the team about these false-positives.