-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#8689ycn7z Update Subscription form for HUB users #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sab-LC
changed the title
Added subscription form for institutions
#8689ycn7z Update Subscription form for HUB users
Oct 1, 2024
lc-hd
reviewed
Oct 4, 2024
lc-hd
reviewed
Oct 4, 2024
lc-hd
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple of comments but in general, looks good to me
I've addressed both the comments. Let me know if there's anything else you'd like me to look into. |
sab-LC
force-pushed
the
8689ycn7z-subscription-form-for-HUB
branch
from
October 10, 2024 19:42
bf3c9e6
to
ed45bf7
Compare
birbjam
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Description:
For accounts that are unsubscribed, they should still be able to access the subscription form from their settings page if they would like to inquire again about a subscription. When clicking on button in either case below, this should lead to the subscription web form. I think the form can prefill with name email and Affiliation/Organization name but allowing the user to edit the name and email in case they have a different contact they'd like to add for the subscription request.
Currently, if Affiliation/Organization is already in the Hub, it redirects the user to join that account. But if the user is brought to this form from that account by clicking the subscription request button, it should still send the request since it would be the admin of that account inquiring about a subscription. (Example: if an anon user or someone not a part of the Local Contexts institution account tries to submit the form for Local Contexts, they would be redirected to request to join the account. If a logged in admin of the Local Contexts account requests a subscription, it allows the form to submit.)
More details of ticket.
Solution:
main.js
to handle the forms validation on frontend.After:
Institutions
lead_data:
{'hubId': '1_i', 'companyName': 'TESTING SABEEN ACCOUNT', 'email': 'sabeen.ammar+909@localcontexts.org', 'firstname': 'institution', 'lastName': 'account', 'oppName': 'TESTING SABEEN ACCOUNT', 'inquiryType': 'Subscription', 'isBusinessTrue': True}
institutionaccount.mp4
Researcher
lead_data:
{'hubId': '1_r', 'companyName': 'researcher account', 'email': 'sabeen.ammar+94449@localcontexts.org', 'firstname': 'researcher', 'lastName': 'account', 'oppName': 'researcher account', 'inquiryType': 'Subscription', 'isBusinessTrue': False}
researcher.mp4