Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc SP bug updates #358

Merged
merged 7 commits into from
Oct 7, 2024
Merged

Misc SP bug updates #358

merged 7 commits into from
Oct 7, 2024

Conversation

arojas1
Copy link
Contributor

@arojas1 arojas1 commented Oct 4, 2024

Misc Bug Fixes:

  • #868a2xg0x: Bug fix, API key count not showing in user settings
  • #868a2xgvv: Bug fix: 404 error when saving preferences settings
  • #8689un1zg: Bug fix SP registry card height

Misc UI updates:

  • #8689un2kg: More info button icon changed to external link indicator
  • #8689q236z: Website link added for all account cards in registry page
  • #8688hmwdm: Filtered out revoked or expired API Keys from showing in user settings

@arojas1 arojas1 self-assigned this Oct 4, 2024
@arojas1
Copy link
Contributor Author

arojas1 commented Oct 4, 2024

Task linked: CU-8688hmwdm Update settings template to handle revoked or expired API Keys
Task linked: CU-8689q236z Account website: add to dash cards
Task linked: CU-8689un1zg Bug fix for SP connections on registry
Task linked: CU-8689un2kg Change icon for 'More Info' button to external link for manual SPs
Task linked: CU-868a2xg0x Bug: API Key count not showing properly for certain accounts
Task linked: CU-868a2xgvv Bug: 404 error hit when registry toggle turned off and saved for SP connection

lc-hd
lc-hd approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@lc-hd lc-hd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! approved

@birbjam birbjam merged commit 40cdcf9 into subscriptions Oct 7, 2024
1 check passed
@birbjam birbjam deleted the misc-sp-bug-updates branch October 7, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@birbjam birbjam birbjam approved these changes

@lc-hd lc-hd lc-hd approved these changes

@sab-LC sab-LC Awaiting requested review from sab-LC

Assignees

@arojas1 arojas1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arojas1 @birbjam @lc-hd