-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch Preview Link module for 'Automatically populating multiple preview link entities' #713
Conversation
…iew link entities' #600
Marking as draft as I need to add some tests and then we can lock the patch file to a specific commit. |
This is now ready for review. This PR simply patches Preview Link. To see it in action you also need the plugins in Guides and Step by Steps which are here: |
There are also PRs adding populate preview link buttons to Directories (localgovdrupal/localgov_directories#376) and Subsites (localgovdrupal/localgov_subsites#146) |
@ekes @finnlewis Would be nice to get this reviewed and merge 😄 |
I'd missed this patch. Testing with step-by-step first. My note on subsites, about levels/depth, still stands though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK so we're already similarly patching this module, so we're hooked there already.
Looked at the plugin and tests and all looks good. Also tested with step-by-step and directories manually.
Drupal issue: https://www.drupal.org/project/preview_link/issues/3439968
Gitlab MR: https://git.drupalcode.org/project/preview_link/-/merge_requests/28
Part of #600