-
Notifications
You must be signed in to change notification settings - Fork 19
enables admin_role module #749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting on localgovdrupal/localgov_core#238 first.
The required version will also need bumping in composer.json so that the module does exist before it tries to install it.
I'm getting the following error about missing the localgov_admin_role module, which is becuase I have a different branch of localgov_core checked out, but this reminds us that we should now bump up the minimum version of localgov_core in the profile to make sure the sub module it there.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This installed the admin role and I could create an administrator and log in as such and perform admin actions.
Note: This required me to be on latest 2.x of localgov_core, as the admin role is not yet included in a release.
Thought: Maybe just rename the role label as Administrator, keep localgov_admin as the internal machine name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 We can get this merged and released now the module as been released as part of LGD Core
@ekes you requested changes in this. Is it okay for you now? Or is there more to do? |
Closes #748
What does this change?
Enables the new
localgov_admin_role
module, so we have a consistent way of working with an admin role.How to test
Install the distro, check that there is now an 'Admin' role and that is set to be the role used for the administrator role.
Thanks to Big Blue Door for sponsoring my time to work on this.