-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dropzonejs composer merge #173
base: 3.x
Are you sure you want to change the base?
Conversation
Discussing in Merge Tuesday: @stephen-cox leaning towards composer-merge plugin rather than the npm asset packagist I suggest we test this again, get the tests running, then merge this to get things moving on localgovdrupal/localgov#729 Note: we'll need to add notes to the README.md and release notes to clarify this appraoch. |
0f43587
to
650f374
Compare
This method does work, with a couple of caveats. Also uninstalling / replacing does require a bit of composer.json surgery to remove it first before adding otherwise a enyo/dropzone can not be found error occurs. |
I think we should go with this! Existing sites will have someone managing the composer.json and can make the call on how to include libraries, following release notes in some cases. For new installs, they will get a good starting point. |
@andybroomfield are we going with it like this? Shall we just merge it? |
@willguv this is the one we're pushing for! With appropriate release notes. |
See localgovdrupal/localgov#729
What does this change?
Adds the wikimedia composer merge plugin, and then uses that to load dropzonejs composer.libraries.json to require the dropzone JS library.
How to test
Composer install or composer update --lock should install the dropzonejs libary once that module is installed.
How can we measure success?
Module gets installed
Have we considered potential risks?
Others may want to have their own dropzone library, so will have to remove this.
Those who have created localgov drupal projects already will need to copy this step.
Images
n/a
Accessibility
n/a