-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] feat: add frontend tooling #184
base: 3.x
Are you sure you want to change the base?
Conversation
@millnut I'm just looking at adding the same commands to ddev |
Great thanks @finnlewis could you commit to this branch I've got some more local changes to push to this as well |
…unctionality added to the Lando config.
@finnlewis @millnut I was looking at some of the localgov_base JS lint issues and thought helpful to share some feedback. The readme references the localgov_base but that project has its own instructions in its readme https://github.com/localgovdrupal/localgov_base/blob/1.x/README.md . Which files to lint (e.g. web/modules/contrib/localgov_base/**/*.css snippet) can be specified in a package.json e.g. line 9 of https://github.com/localgovdrupal/localgov_base/blob/1.x/package.json . There may well be a place for scanning and making changes at this level (for installing core packages / for custom code / to scan for problems to create tasks). The most important thing is that we have a consistent approach so everyone gets the same output. I think it would be great if the readme could include some context about the use cases. |
What does this change?
Fixes #183. This adds frontend tooling for Lando and DDEV for eslint and stylelint.
WIP: DDEV config to do