This repository was archived by the owner on Aug 7, 2025. It is now read-only.
Replace hardcoded URLs with ref shortcodes#1771
Merged
viren-nadkarni merged 5 commits intomainfrom Jun 2, 2025
Merged
Conversation
|
🎊 PR Preview has been successfully built and deployed to https://localstack-docs-preview-pr-1771.surge.sh 🎊 |
viren-nadkarni
force-pushed
the
hardcoded-urls
branch
from
c54d48a to
f027d87
Compare
viren-nadkarni
force-pushed
the
hardcoded-urls
branch
2 times, most recently
from
41ced7d to
e55ee66
Compare
viren-nadkarni
force-pushed
the
hardcoded-urls
branch
from
94b630f to
81f0475
Compare
viren-nadkarni
force-pushed
the
hardcoded-urls
branch
from
a336004 to
9e62b44
Compare
viren-nadkarni
requested review from
HarshCasper,
MEPalma,
baermat,
bentsku,
cloutierMat,
dfangl,
dominikschubert,
giograno,
gregfurman,
joe4dev,
lukqw,
macnev2013,
nik-localstack,
pinzon,
sannya-singal,
silv-io,
steffyP and
thrau
as code owners
viren-nadkarni
requested review from
quetzalliwrites
and removed request for
MEPalma,
alexrashed,
anisaoshafi,
baermat,
bentsku,
cloutierMat,
dfangl,
dominikschubert,
giograno,
gregfurman,
joe4dev,
lukqw,
macnev2013,
maxhoheiser,
nik-localstack,
pandomic,
pinzon,
sannya-singal,
silv-io,
simonrw,
steffyP,
thrau and
tiurin
HarshCasper
approved these changes
May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces hardcoded internal links with the
refshortcode.Hardcoded URLs don't work when hosting docs locally — they point to the deployed docs. The
refshortcode is better in this regard, plus it also detects broken links at build time.