Open
Conversation
Terraform Test Results2 tests 1 ✅ 33s ⏱️ For more details on these failures, see this check. Results for commit aa5a640. ♻️ This comment has been updated with latest results. |
dmacvicar
force-pushed
the
feature/uv-migration
branch
from
eeb7349 to
aa5a640
Compare
dmacvicar
changed the title
Replace pip + requirements.txt with uv for faster installs and lockfile-based reproducibility. Move dependencies to pyproject.toml, update Makefile and CI workflows to use uv sync/run.
dmacvicar
force-pushed
the
feature/uv-migration
branch
from
aa5a640 to
9c50027
Compare
macnev2013
requested changes
Mar 20, 2026
Collaborator
macnev2013
left a comment
macnev2013
left a comment
There was a problem hiding this comment.
Looks good to me. Just a minor comment regarding the virutalenv.
Collaborator
There was a problem hiding this comment.
The venv target and VENV_DIR/VENV_RUN variables can be removed — uv sync automatically creates and manages the .venv, and uv run handles activation implicitly. The install target doesn't need venv as a dependency, and prepare-organizations can use uv run instead of manually sourcing the activate script.
uv sync already creates and manages .venv, and uv run handles activation implicitly, so the venv target and VENV_DIR/VENV_RUN variables are unnecessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.