Conversation
Collaborator
Author
|
Example: 2025-09-04 12:32:29.979 [trace] [extension.dependencies]: Starting...
2025-09-04 12:32:29.979 [debug] [container-status.listenToContainerStatus] Spawning 'docker events'...
2025-09-04 12:32:29.979 [trace] [container-status.getContainerStatus]: Starting...
2025-09-04 12:32:29.980 [trace] [container-status.getContainerStatus]: Completed in 232 ms
2025-09-04 12:32:29.980 [trace] [localstack-status.healthCheck]: Starting...
2025-09-04 12:32:29.984 [trace] [localstack-status.healthCheck]: Completed in 14 ms
2025-09-04 12:32:29.984 [trace] [setup-status-tracker]: Starting...
2025-09-04 12:32:29.984 [trace] [setup-status-tracker]: Initialized dependencies in 0 ms
2025-09-04 12:32:29.984 [trace] [setup-status-tracker.checkIsSetupRequired]: Starting...
2025-09-04 12:32:30.417 [trace] [setup-status-tracker.checkIsSetupRequired]: Completed in 433 ms
2025-09-04 12:32:30.418 [trace] [setup-status-tracker]: Completed in 434 ms
2025-09-04 12:32:30.418 [trace] [telemetry]: Starting...
2025-09-04 12:32:30.418 [trace] [telemetry]: Completed in 0 ms
2025-09-04 12:32:30.418 [trace] [extension.dependencies]: Completed in 682 ms
2025-09-04 12:32:30.418 [trace] [extension.activatePlugins]: Starting...
2025-09-04 12:32:30.418 [trace] [extension.plugins]: Activating plugin "setup"...
2025-09-04 12:32:30.419 [trace] [extension.plugins]: Activated plugin "setup" in 0 ms
2025-09-04 12:32:30.419 [trace] [extension.plugins]: Activating plugin "authenticate"...
2025-09-04 12:32:30.419 [trace] [extension.plugins]: Activated plugin "authenticate" in 1 ms
2025-09-04 12:32:30.419 [trace] [extension.plugins]: Activating plugin "configure-aws"...
2025-09-04 12:32:30.419 [trace] [extension.plugins]: Activated plugin "configure-aws" in 0 ms
2025-09-04 12:32:30.419 [trace] [extension.plugins]: Activating plugin "manage"...
2025-09-04 12:32:30.419 [trace] [extension.plugins]: Activated plugin "manage" in 0 ms
2025-09-04 12:32:30.419 [trace] [extension.plugins]: Activating plugin "status-bar"...
2025-09-04 12:32:30.419 [trace] [extension.plugins]: Activated plugin "status-bar" in 0 ms
2025-09-04 12:32:30.419 [trace] [extension.plugins]: Activating plugin "logs"...
2025-09-04 12:32:30.419 [trace] [extension.plugins]: Activated plugin "logs" in 0 ms
2025-09-04 12:32:30.419 [trace] [extension.activatePlugins]: Completed in 1 ms
|
skyrpex
commented
Sep 4, 2025
skyrpex
force-pushed
the
track-extension-startup-times
branch
from
4c17dfa to
93932f9
Compare
anisaoshafi
reviewed
Sep 4, 2025
| options.outputChannel.error( | ||
| `[${name}]: Failed after ${timeDiff(start, end)}`, | ||
| ); | ||
| throw error; |
Collaborator
There was a problem hiding this comment.
What happens when the error is thrown? I'm trying to understand this specific behaviour
Collaborator
Author
There was a problem hiding this comment.
In the case of an error being thrown, we log the error to the output channel, and re-throw the error. This means that using the time tracker doesn't have any impact on the logic of the tracked callback -- it just logs the time it took either to complete or fail.
anisaoshafi
reviewed
Sep 4, 2025
anisaoshafi
reviewed
Sep 4, 2025
anisaoshafi
reviewed
Sep 4, 2025
anisaoshafi
reviewed
Sep 4, 2025
anisaoshafi
reviewed
Sep 4, 2025
Comment on lines
+91
to
+98
| return { | ||
| statusBarItem, | ||
| containerStatusTracker, | ||
| localStackStatusTracker, | ||
| setupStatusTracker, | ||
| telemetry, | ||
| }; | ||
| }); |
Collaborator
There was a problem hiding this comment.
what is the reason of returning these now? 👀
Collaborator
Author
There was a problem hiding this comment.
statusBarItem, telemetry, etc. are now created inside of a timeTracker.run(...) callback, so they aren't available outside of the callback. To solve this, we take advantage of timeTracker.run(...) returning back the stuff from the callback.
const {
statusBarItem,
} = await timeTracker.run("extension.dependencies", async () => {
// Not available outside of this callback.
const statusBarItem = window.createStatusBarItem(
StatusBarAlignment.Left,
-1,
);
// ...
// Return them so they can be grabbed outside.
return {
statusBarItem,
};
});
Collaborator
There was a problem hiding this comment.
got it, thanks for clarifying that!
Co-authored-by: Anisa Oshafi <anisaoshafi@gmail.com>
Co-authored-by: Anisa Oshafi <anisaoshafi@gmail.com>
Co-authored-by: Anisa Oshafi <anisaoshafi@gmail.com>
Co-authored-by: Anisa Oshafi <anisaoshafi@gmail.com>
anisaoshafi
approved these changes
Sep 4, 2025
Collaborator
anisaoshafi
left a comment
anisaoshafi
left a comment
There was a problem hiding this comment.
LGTM 🚀 impressed by how quickly you put this code together!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds profiling traces to the output channel for the startup times of the extension and its plugins.