Skip to content

Comments

chore: separate test and list ci jobs#25

Merged
anisaoshafi merged 1 commit intomainfrom
separate-test-and-list-ci-jobs
Sep 4, 2025
Merged

chore: separate test and list ci jobs#25
anisaoshafi merged 1 commit intomainfrom
separate-test-and-list-ci-jobs

Conversation

@skyrpex
Copy link
Collaborator

@skyrpex skyrpex commented Sep 4, 2025

Currently, linting, compiling and testing happens during the same CI job, making it hard to distinguish if the CI didn’t pass because of a linting issue or because the code does not work.

This change separates the current build job into two: lint and test. Hopefully, it will bring more clarity into pull request checks.

Currently, linting, compiling and testing happens during the same CI 
job, making it hard to distinguish if the CI didn’t pass because of a 
linting issue or because the code does not work.

This change separates the current build job into two: lint and test.
@skyrpex
Copy link
Collaborator Author

skyrpex commented Sep 4, 2025

@tiurin @anisaoshafi do you have permissions to update the repository's mandatory checks? In case we want to merge this, we have to remove "Build" and add both "Build / Lint" and "Build / Test".

@anisaoshafi
Copy link
Collaborator

@tiurin @anisaoshafi do you have permissions to update the repository's mandatory checks? In case we want to merge this, we have to remove "Build" and add both "Build / Lint" and "Build / Test".

I have permissions and will do it after merging 🏃🏼

@anisaoshafi anisaoshafi enabled auto-merge (squash) September 4, 2025 12:04
@anisaoshafi anisaoshafi merged commit c3b05a9 into main Sep 4, 2025
3 checks passed
@anisaoshafi anisaoshafi deleted the separate-test-and-list-ci-jobs branch September 4, 2025 12:05
@anisaoshafi
Copy link
Collaborator

anisaoshafi commented Sep 4, 2025

@skyrpex

  1. removed old check and added the new checks ✅
  2. assigned you admin role in the repo so you can autonomously make changes 🔑

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants