Conversation
tiurin
reviewed
Sep 4, 2025
Collaborator
tiurin
left a comment
tiurin
left a comment
There was a problem hiding this comment.
I have a couple of questions to clarify but overall great fixes! 👏
skyrpex
force-pushed
the
reflect-localstack-status-immediately-after-running-start-and-stop-commands
branch
from
0b244d2 to
d988a5a
Compare
…top commands Makes the status bar display that LS is either starting or stopping immediately after executing the respective LS commands.
…top commands Makes the status bar display that LS is either starting or stopping immediately after executing the respective LS commands.
…top commands Makes the status bar display that LS is either starting or stopping immediately after executing the respective LS commands.
…top commands Makes the status bar display that LS is either starting or stopping immediately after executing the respective LS commands.
skyrpex
force-pushed
the
reflect-localstack-status-immediately-after-running-start-and-stop-commands
branch
from
d988a5a to
3c4c3da
Compare
…running-start-and-stop-commands
skyrpex
deleted the
reflect-localstack-status-immediately-after-running-start-and-stop-commands
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one is delicate: we synthetically force the container status to "running", "stopping" and "stopped" to give the user the immediate effect of their actions on the status bar.
In order to do so I refactored a bit our spawn helpers, no big deal, they are now just a bit more complex. On top of that, our localstack start --detached invocation is a bit more complex: we look for a specific error string in its stderr output - in that case, we kill the process and throw an error. In turn, we force back the container status to "stopped".