chore: enrich and improve telemetry events #29
Merged
Conversation
12318b7 to
8c48605
Compare
skyrpex
reviewed
Sep 5, 2025
skyrpex
approved these changes
Sep 5, 2025
Collaborator
skyrpex
left a comment
There was a problem hiding this comment.
Thank you, great job with the changes... Hope that the git conflict is easy to solve. I can help otherwise.
6ccaa05 to
62a515c
Compare
tiurin
requested changes
Sep 5, 2025
Collaborator
tiurin
left a comment
There was a problem hiding this comment.
Thank you for adding telemetry to licensing code and for the rest of improvements!
There is one incorrect status report that needs to be fixed and the rest are non-blocking suggestions.
tiurin
reviewed
Sep 5, 2025
7658c70 to
906f37f
Compare
tiurin
reviewed
Sep 8, 2025
5f67cd8 to
01394a6
Compare
01394a6 to
776fefa
Compare
776fefa to
1d20bd6
Compare
tiurin
approved these changes
Sep 9, 2025
| } | ||
|
|
||
| export function get_setup_ended( | ||
| cli_status: "COMPLETED" | "SKIPPED" | "CANCELLED", |
Collaborator
There was a problem hiding this comment.
👍 Let's iterate on positional arguments vs. a record in the upcoming PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
auth_tokento events afterauth_token_configured(read it from .localstack/auth.json file when possible)session_idcapture rate foremulator.startedeventsexpected_stepsfromsetup_startedeventpositiontostep_orderSCHEMA_VERSION: 1 -> 2license_setup_endedevent[1] We were not capturing the emulator session_id quite well in the emulator.started events.
We rely on endpoint http://localhost:4566/_localstack/info to grab it, however the endpoint is not immediately available when we just start localstack (needs to be in running state). It needs a couple of seconds before it's accessible (some 4-6 seconds in my local tests).
Now we retry up to 10x and wait 1s each time before sending the event to make sure we get the session_id as often as possible.