Merged
Conversation
Collaborator
skyrpex
commented
Sep 5, 2025
skyrpex
commented
- Show a modal before starting the authentication redirect
- In rare cases, telemetry wouldn’t track if the authentication process was canceled
anisaoshafi
reviewed
Sep 5, 2025
- Show a modal before starting the authentication redirect - In rare cases, telemetry wouldn’t track if the authentication process was canceled
skyrpex
force-pushed
the
improve-authentication-flow
branch
from
f822916 to
2a4d097
Compare
anisaoshafi
approved these changes
Sep 5, 2025
Collaborator
anisaoshafi
left a comment
anisaoshafi
left a comment
There was a problem hiding this comment.
Thanks for improving this 🔍
I also noticed this when tracking the events, but forgot to log a ticket or TODO.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.