Conversation
anisaoshafi
reviewed
Sep 8, 2025
| if (healthCheck === true) { | ||
| return "running"; | ||
| } else { | ||
| if (previousStatus === "running" || previousStatus === "stopping") { |
Collaborator
There was a problem hiding this comment.
if previousStatus is stopping, shouldn't we return starting?
Collaborator
Author
There was a problem hiding this comment.
It's a good question and I guess it deserves an explanatory comment in-code.
Without the || previousStatus === "stopping" check, we get a wrong behavior:
- When stopping LS externally, we would first go from "running" to "stopping", which is correct.
- But the next health check will go from "stopping" to "starting", which is wrong.
Collaborator
There was a problem hiding this comment.
That was tricky, and the explanation is very clear 🙌🏼
…ernally Fix status bar incorrectly reporting LocalStack as starting when stopping in certain scenarios
skyrpex
force-pushed
the
fix-invalid-status-reported-when-stopping-localstack-externally
branch
from
6003ff2 to
d601de2
Compare
anisaoshafi
approved these changes
Sep 8, 2025
skyrpex
deleted the
fix-invalid-status-reported-when-stopping-localstack-externally
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix status bar incorrectly reporting LocalStack as starting when stopping in certain scenarios