Skip to content

chore(telemetry): add origin for setup_ended #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anisaoshafi merged 1 commit into from
Sep 10, 2025
Merged

chore(telemetry): add origin for setup_ended #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/plugins/setup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
},
});

window.withProgress(

Check warning on line 46 in src/plugins/setup.ts

View workflow job for this annotation

GitHub Actions / Lint 

Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator
{
location: ProgressLocation.Notification,
title: "Setup LocalStack",
Expand Down Expand Up @@ -82,6 +82,7 @@
"SKIPPED",
"SKIPPED",
"CANCELLED",
origin_trigger,
),
);
return;
Expand Down Expand Up @@ -121,6 +122,7 @@
"SKIPPED",
"SKIPPED",
"CANCELLED",
origin_trigger,
await readAuthToken(),
),
);
Expand Down Expand Up @@ -176,6 +178,7 @@
"SKIPPED",
"SKIPPED",
"CANCELLED",
origin_trigger,
await readAuthToken(),
),
);
Expand Down Expand Up @@ -207,6 +210,7 @@
"SKIPPED",
"SKIPPED",
"CANCELLED",
origin_trigger,
authToken,
),
);
Expand Down Expand Up @@ -261,6 +265,7 @@
"CANCELLED",
"SKIPPED",
"CANCELLED",
origin_trigger,
await readAuthToken(),
),
);
Expand Down Expand Up @@ -314,6 +319,7 @@
"COMPLETED",
"COMPLETED",
"CANCELLED",
origin_trigger,
await readAuthToken(),
),
);
Expand All @@ -322,25 +328,25 @@

/////////////////////////////////////////////////////////////////////
if (localStackStatusTracker.status() === "running") {
window

Check warning on line 331 in src/plugins/setup.ts

View workflow job for this annotation

GitHub Actions / Lint 

Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator
.showInformationMessage("LocalStack is running.", {
title: "View Logs",
command: "localstack.viewLogs",
})
.then((selection) => {
if (selection) {
commands.executeCommand(selection.command);

Check warning on line 338 in src/plugins/setup.ts

View workflow job for this annotation

GitHub Actions / Lint 

Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator
}
});
} else {
window

Check warning on line 342 in src/plugins/setup.ts

View workflow job for this annotation

GitHub Actions / Lint 

Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator
.showInformationMessage("LocalStack is ready to start.", {
title: "Start LocalStack",
command: "localstack.start",
})
.then((selection) => {
if (selection) {
commands.executeCommand(selection.command);

Check warning on line 349 in src/plugins/setup.ts

View workflow job for this annotation

GitHub Actions / Lint 

Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator
}
});
}
Expand All @@ -352,6 +358,7 @@
"COMPLETED",
"COMPLETED",
"COMPLETED",
origin_trigger,
await readAuthToken(),
),
);
Expand All @@ -362,14 +369,14 @@
);

if (setupStatusTracker.status() === "setup_required") {
window

Check warning on line 372 in src/plugins/setup.ts

View workflow job for this annotation

GitHub Actions / Lint 

Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator
.showInformationMessage("Setup LocalStack to get started.", {
title: "Setup",
command: "localstack.setup",
})
.then((selected) => {
if (selected) {
commands.executeCommand(selected.command, "extension_startup");

Check warning on line 379 in src/plugins/setup.ts

View workflow job for this annotation

GitHub Actions / Lint 

Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator
}
});
}
Expand Down
3 changes: 3 additions & 0 deletions src/utils/telemetry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ type Events =
name: "setup_ended";
payload: {
namespace: "onboarding";
origin: "manual_trigger" | "extension_startup";
steps: [
{
name: "emulator_installed";
Expand Down Expand Up @@ -220,12 +221,14 @@ export function get_setup_ended(
license_setup_status: "COMPLETED" | "SKIPPED" | "CANCELLED",
aws_profile_status: "COMPLETED" | "SKIPPED" | "CANCELLED",
overall_status: "CANCELLED" | "COMPLETED",
origin: "manual_trigger" | "extension_startup",
auth_token: string = "",
): Events {
return {
name: "setup_ended",
payload: {
namespace: "onboarding",
origin,
steps: [
{
name: "emulator_installed",
Expand Down
Loading