Use jpype-ext and set jpype interrupt=False #11877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfangl
added
the
semver: patch
S3 Image Test Results (AMD64 / ARM64) 2 files 2 suites 4m 11s ⏱️ Results for commit a4a45a5. |
maxhoheiser
approved these changes
Nov 19, 2024
Member
maxhoheiser
left a comment
maxhoheiser
left a comment
There was a problem hiding this comment.
LGTMT - thanks for addressing this Daniel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, jpype1 only installs SIGINT signal handlers if
interrupt=False. With localstack/jpype#1, we (very crudely) added support for SIGTERM as well.We should aim to upstream this changes ASAP, but for the 4.0 release, this should suffice to get proper shutdown handling in LocalStack even if a library is loaded using jpype.
Changes
interrupt=Falsewhen starting jpype