Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix feed rendering #779

Closed
wants to merge 1 commit into from

Conversation

hannesbochmann
Copy link
Contributor

@okmiim okmiim self-assigned this Dec 2, 2023
@okmiim
Copy link
Collaborator

okmiim commented Dec 3, 2023

Hi @hannesbochmann,
thank you for the contribution and investigation.
You are actually right with $response->getBody()->__toString() (or event better with rewind()).
The other problem (with my other test-implementations) were wrong response codes on pages with multiple actions.

I will not merge your PR in favor of e7af8ba, since I made some other improvements (PropagateResponseException). But still, through your contribution I found the "blocking error" 😉 .

@okmiim okmiim closed this Dec 3, 2023
@hannesbochmann
Copy link
Contributor Author

Glad I could help and thanks for your effort :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants