Skip to content

Conversation

@sebj54
Copy link

@sebj54 sebj54 commented Nov 7, 2021

In my case, queueData is always null so it crashes the app every time onMediaStatusUpdate is called. I added this little check to avoid the crash.

I was not able to use the publish/pack.sh script. It fails every time because it does not find the build.angular npm script. I think there is something wrong with the cd .. line before the angular build part. I tried to remove it but it fails anyway after that.

Error: The Angular Compiler requires TypeScript >=3.9.2 and <4.1.0 but 4.1.3 was found instead.

Maybe TypeScript version should be pinned in package.json and npm ci should be used instead of npm i in pack.sh script?

Let me know if I can do something on my side to help you publish a new version!

@lochstar
Copy link
Owner

lochstar commented Nov 7, 2021

Thanks, I did notice this same crash when migrating the project to the plugin-seed: https://github.com/lochstar/nativescript-cast/blob/plugin-seed/src/cast.android.ts#L834

I need to take another look at that branch and finish off what I started.

@sebj54
Copy link
Author

sebj54 commented Nov 8, 2021

Great! Let me know if I can help in any way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants