Skip to content

Commit

Permalink
code review fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
theosanderson committed Mar 9, 2024
1 parent a6f0459 commit a8ae267
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 17 deletions.
10 changes: 2 additions & 8 deletions website/src/components/User/ListOfGroupsOfUser.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -64,14 +64,8 @@ const InnerListOfGroupsOfUser: FC<ListOfGroupsOfUserProps> = ({
))
) : (
<p className='text-gray-600 text-sm'>
You are not currently a member of a group. If you intend to submit sequences, you can{' '}
<a
href={routes.createGroup()}
className='text-primary-500 hover:underline focus:underline active:underline'
>
create a group
</a>
, or you can ask an administrator of an existing group to add you to their group.
You are not currently a member of a group. If you intend to submit sequences, please create a
group or ask an administrator of an existing group to add you to their group.
</p>
)}
</ul>
Expand Down
14 changes: 8 additions & 6 deletions website/src/pages/[organism]/submission/index.astro
Original file line number Diff line number Diff line change
@@ -1,18 +1,20 @@
---
import { cleanOrganism } from '../../../components/Navigation/cleanOrganism';
import BaseLayout from '../../../layouts/BaseLayout.astro';
import { routes } from '../../../routes';
const { organism } = Astro.params;
const { organism } = cleanOrganism(Astro.params.organism);
---

<BaseLayout title='Submit'>
<h1 class='title'>Submission portal for {organism!}</h1>
<h1 class='title'>Submission portal for {organism!.displayName}</h1>

<div>
<a href={routes.submitPage(organism!)}>Make a new submission</a><br />
<a href={routes.revisePage(organism!)}>Make a revision</a>
<a href={routes.submitPage(organism!.key)}>Make a new submission</a><br />
<a href={routes.revisePage(organism!.key)}>Make a revision</a>
<br />
<a href={routes.userSequenceReviewPage(organism!)}>My unreleased sequences</a>
<a href={routes.userSequenceReviewPage(organism!.key)}>My unreleased sequences</a>
<br />
<a href={routes.mySequencesWithoutGroup(organism!)}>My released sequences</a>
<a href={routes.mySequencesWithoutGroup(organism!.key)}>My released sequences</a>
</div>
</BaseLayout>
4 changes: 1 addition & 3 deletions website/tests/pages/user/userPage/userPage.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
import type { Page } from '@playwright/test';

import { routes } from '../../../../src/routes.ts';
import type { AccessionVersion, SequenceEntryStatus } from '../../../../src/types/backend.ts';
import { getAccessionVersionString } from '../../../../src/utils/extractAccessionVersion.ts';
import { baseUrl, dummyOrganism, expect } from '../../../e2e.fixture.ts';
import { baseUrl, expect } from '../../../e2e.fixture.ts';

export class UserPage {
constructor(public readonly page: Page) {}
Expand Down

0 comments on commit a8ae267

Please sign in to comment.