Skip to content

Commit

Permalink
feat(ci): speed up E2E by helm deploying before installing playwright…
Browse files Browse the repository at this point in the history
… deps (#1309)

"Wait for pods to be ready" is rate limiting right now, so starting the deployment
as early as possible should save time
  • Loading branch information
corneliusroemer committed Mar 10, 2024
1 parent 6b97f8e commit b6454ae
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/e2e-k3d.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,11 @@ jobs:
name: default-helm-template
path: defaultTemplate.yaml

- name: Deploy with helm
uses: WyriHaximus/github-action-helm3@v4
with:
exec: ./deploy.py --verbose helm --branch ${{ github.ref_name }} --sha ${{ github.sha }} --dockerconfigjson ${{ secrets.GHCR_DOCKER_CONFIG }}

- uses: actions/setup-node@v4
with:
node-version: 20
Expand Down Expand Up @@ -84,11 +89,6 @@ jobs:
run: cd website && npx playwright install-deps
if: steps.playwright-cache.outputs.cache-hit == 'true'

- name: Deploy with helm
uses: WyriHaximus/github-action-helm3@v4
with:
exec: ./deploy.py --verbose helm --branch ${{ github.ref_name }} --sha ${{ github.sha }} --dockerconfigjson ${{ secrets.GHCR_DOCKER_CONFIG }}

# Waits are identical to the update-argocd-metadata.yml file
# Mirror changes to that file
- name: Wait for Prepro Dummy Docker Image
Expand Down

0 comments on commit b6454ae

Please sign in to comment.