Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show submissionId as editable field on edit page #2121

Closed
corneliusroemer opened this issue Jun 10, 2024 · 2 comments
Closed

Don't show submissionId as editable field on edit page #2121

corneliusroemer opened this issue Jun 10, 2024 · 2 comments
Assignees
@anna-parker
Labels
website Tasks related to the web application
Milestone
MVP

Comments

@corneliusroemer
Copy link
Contributor

I'm not sure it makes sense to allow editing of the submissionId field on the edit page.

SubmissionId is tightly coupled to the sequences.fasta submission file. As we've already parsed the submitted files, we probably don't want to allow editing of submissionId post-submission.

Brave Browser 2024-06-10 18 33 37
@corneliusroemer corneliusroemer added the website Tasks related to the web application label Jun 10, 2024
@chaoran-chen chaoran-chen added this to the MVP milestone Jul 4, 2024
@anna-parker anna-parker self-assigned this Jul 25, 2024
@anna-parker anna-parker mentioned this issue Jul 25, 2024
Merged
@theosanderson
Copy link
Member

This was fixed in #2121

@fengelniederhammer
Copy link
Contributor

You probably meant #2334 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anna-parker anna-parker

Labels
website Tasks related to the web application
Projects
Planning
Archived in project
Milestone
MVP
Development

No branches or pull requests
5 participants
@chaoran-chen @theosanderson @corneliusroemer @anna-parker @fengelniederhammer