Do not allow submissionId to be editable

[anna-parker]

resolves ##2121

preview URL: https://fix-submitterid.loculus.org/

Summary

Current state: submitter Id field is empty (the contents do appear when metadata is downloaded - so I don't know why this is currently empty) and arbitrary content can be added:

There are 2 issues here, the first is that the submitterId is not actually passed to the website from the backend, but also that the submitterId is still in the list of original metadata although the value is not there.

• Pass submissionId to website from backend
• Remove submissionId from original, editable metadata list by adding a noEdit field in the config.
• Add submissionId as a non-editable field

Testing

Locally I checked that the submitterId is still returned in the downloaded metadata and is seen on the sequence details page after release:

[theosanderson]

I think your earlier version had this just displayed in a non-editable format? I think that's pretty useful because if the user submitted their sample, which they know only by their own ID Crick_sample_A123 then they won't be able to enter the corresponding metadata without referring to that ID.

[theosanderson]

I guess you did this because of this empty thing. I can try to look into what's going on there.

[theosanderson]

Working on: #2336

[theosanderson]

Interestingly I tried on main to see the submissionId on the edit page for dummy organism but couldn't. Maybe dummy organism is set up differently. (Then I tried ebola, but hit #2339 so couldn't confirm either way)

[anna-parker]

@theosanderson thanks for looking into the submitterId - I fixed adding it here to the webpage - will push my changes in a bit!

[theosanderson]

This is great! Thanks a lot

[fengelniederhammer]

I wonder why this was necessary at all? We have a bunch of loculus internal metadata, why did this only show up for the submission id? Is it becaus the submission id somehow made it to the values.yaml although it should be only in the _common-metadata.tpl?

[theosanderson]

Yes I have a feeling that's right and that in fact it was only present for some organisms because I couldn't reproduce this for dummyOrganism (which is the only place I tried)

[fengelniederhammer]

Should we maybe revert this PR and instead fix it in the values.yml (for the sake of complexity)?

[theosanderson]

No, this PR achieved stuff we need: the submissionId should be displayed but in a non-editable form. The reason it needs to be displayed is that users need to refer to it to look up the correct metadata to enter

[theosanderson]

(the thing that may not be needed is the noEdit setting, no strong feelings there)