Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): Add href to actual status page in footer #1153

Closed
wants to merge 1 commit into from

Conversation

corneliusroemer
Copy link
Contributor

@corneliusroemer corneliusroemer commented Feb 26, 2024

@corneliusroemer corneliusroemer added the preview Triggers a deployment to argocd label Feb 26, 2024
Copy link
Member

@theosanderson theosanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this quite works - people should be able to deploy this image to run their loculus DB. This status page wouldn't make sense in that context. I think we need to figure out what the continuing "Loculus"-branded instance we plan to run is before we launch a status page for it.

@corneliusroemer
Copy link
Contributor Author

Fair point @theosanderson - we should make this a configurable link

@corneliusroemer corneliusroemer marked this pull request as draft February 26, 2024 20:40
@theosanderson theosanderson removed the preview Triggers a deployment to argocd label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants