-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retag images to reduce time spent on recomputing unchanged docker images #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theosanderson
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks cool
Cool! How much time is it saving and could you please provide a brief summary of what you changed? :) |
This reverts commit 34201486d94e293c6bbd93329e4e34a2fcc91e39.
corneliusroemer
force-pushed
the
retag-images
branch
from
February 28, 2024 16:05
d162853
to
2305c4b
Compare
Done @chaoran-chen this is how fast it is now: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bypass building docker images when all relevant input files have not changed (akin to NixOS)
This way, docker builds are only done when necessary. You change website only in a commit, then no need to build a new backend docker image.
Docker build times were roughly:
The bypass workflow completes in 20s.
Benefit is not just that we save a few Github action minutes, but also that preview builds are up much faster when only config is changed, this should be particularly helpful for @theosanderson