Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): Improve label text of the "show errors" checkbox on submission review page #1289

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

corneliusroemer
Copy link
Contributor

@corneliusroemer corneliusroemer commented Mar 9, 2024

preview URL: https://fix-text.loculus.org

Summary

The checkbox controls whether entries with errors are shown or hidden - not whether errors are shown.

Screenshot

Before:
image

After:
image

The checkbox controls whether entries with errors are shown or hidden - not whether errors are shown.
@corneliusroemer corneliusroemer added preview Triggers a deployment to argocd javascript labels Mar 9, 2024
@corneliusroemer corneliusroemer enabled auto-merge (squash) March 9, 2024 15:09
@corneliusroemer
Copy link
Contributor Author

I use "entry" here as this is what I think we call the combination of "sequence + metadata" - but I noticed that the status message above says "10 of 10 sequences processed". What's our user-facing terminology? Entry or sequence, or something different altogether, or do we use them as synonyms?

@corneliusroemer corneliusroemer changed the title fix(website): Correct label of the "show errors" checkbox fix(website): Improve label text of the "show errors" checkbox on submission review page Mar 9, 2024
@corneliusroemer corneliusroemer merged commit c0f531a into main Mar 9, 2024
12 checks passed
@corneliusroemer corneliusroemer deleted the fix-text branch March 9, 2024 16:22
@chaoran-chen
Copy link
Member

I think entries sound good here and it's clear what is meant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Triggers a deployment to argocd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants