Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): show authors at the top on sequence details page #1729

Merged
merged 1 commit into from
May 5, 2024

Conversation

chaoran-chen
Copy link
Member

@chaoran-chen chaoran-chen commented May 1, 2024

preview URL: https://seq-details-authors.loculus.org

Summary

This moves the author list (if there is one) to the top of the sequence details page. The list is shortened if there are >= 28 authors.

Screenshot

image

PR Checklist

  • [ ] All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate test.

@chaoran-chen chaoran-chen added the preview Triggers a deployment to argocd label May 1, 2024
@chaoran-chen chaoran-chen marked this pull request as ready for review May 1, 2024 21:25
@chaoran-chen chaoran-chen added this to the MVP milestone May 1, 2024
@chaoran-chen chaoran-chen added the website Tasks related to the web application label May 1, 2024
@chaoran-chen chaoran-chen force-pushed the seq-details-authors branch 2 times, most recently from cbf53ee to a85488e Compare May 2, 2024 11:40
@corneliusroemer
Copy link
Contributor

corneliusroemer commented May 2, 2024

Getting a React error here:
https://seq-details-authors.loculus.org/ebola-zaire/search

Something about React: "There was an error while hydrating but React was able to recover by instead client rendering the entire root."
image

Logs also contain something (potentially unrelated):

Warning: Invalid DOM property `autocomplete`. Did you mean `autoComplete`?    at textarea    at div    at file:///app/dist/server/chunks/pages/index_YG102ae5.mjs:3090:11    at file:///app/dist/server/chunks/pages/index_YG102ae5.mjs:3164:11    at AccessionField (file:///app/dist/server/chunks/pages/index_YG102ae5.mjs:3182:27)    at div    at form    at div    at div    at QueryClientProvider (file:///app/node_modules/@tanstack/react-query/build/lib/QueryClientProvider.mjs:41:3)    at SearchForm (file:///app/dist/server/chunks/pages/index_YG102ae5.mjs:4670:3)    at div    at div    at SearchFullUI (file:///app/dist/server/chunks/pages/index_YG102ae5.mjs:5084:3)

@chaoran-chen
Copy link
Member Author

Very weird! I also observed it but now the page works again.

@corneliusroemer
Copy link
Contributor

corneliusroemer commented May 2, 2024

Could it be failing when there are no sequences in LAPIS? The new sequences were submitted and released yesterday which is confusing - why is it only them showing up now. Something odd is going on.

image

I think that ingest ran on the old database before it was wiped. I can reintroduce a delay on main to fix this until we merge reingest. Still search shouldn't error when there are no sequences.

@chaoran-chen
Copy link
Member Author

I submitted the two sequences manually yesterday and at the moment, the database is not getting reset upon new commits: #1735

@chaoran-chen chaoran-chen force-pushed the seq-details-authors branch 2 times, most recently from ba8dd3c to b60f30a Compare May 2, 2024 13:20
@anna-parker
Copy link
Contributor

Sorry if I'm late to the game here - I still don't see any sequence mutation information here in the preview - do we need to restart the preview now that #1735 is merged?

@theosanderson
Copy link
Member

Good point! I don't think this will be a matter of restarting previews

@chaoran-chen chaoran-chen merged commit 168af37 into main May 5, 2024
14 checks passed
@chaoran-chen chaoran-chen deleted the seq-details-authors branch May 5, 2024 17:55
corneliusroemer added a commit that referenced this pull request May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Triggers a deployment to argocd website Tasks related to the web application
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants