Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): remove layout shift when file picked on submit page #1974

Merged
merged 2 commits into from
May 21, 2024

Conversation

corneliusroemer
Copy link
Contributor

preview URL: https://fix-layout-shif.loculus.org

Screenshot

Before:
2024-05-21 03 25 00

After:
2024-05-21 03 25 23

@corneliusroemer corneliusroemer added the preview Triggers a deployment to argocd label May 21, 2024
@chaoran-chen chaoran-chen changed the title fix(submit-page): remove layout shift when file picked fix(website): remove layout shift when file picked on submit page May 21, 2024
Copy link
Member

@chaoran-chen chaoran-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

(Regarding commit messages: please only use one of our usual scopes and don't invent new ones :))

@corneliusroemer corneliusroemer merged commit 698b836 into main May 21, 2024
13 checks passed
@corneliusroemer corneliusroemer deleted the fix-layout-shift branch May 21, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Triggers a deployment to argocd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants