Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): allow customizing columns #1993

Merged
merged 10 commits into from
Jun 19, 2024
Merged

Conversation

theosanderson
Copy link
Member

@theosanderson theosanderson commented May 21, 2024

Resolves #83

Allows customizing the columns in the search table. Adds a test for this feature. https://customize-columns.loculus.org/

image

@theosanderson theosanderson added RFC preview Triggers a deployment to argocd labels May 21, 2024
@corneliusroemer
Copy link
Contributor

corneliusroemer commented May 27, 2024

This is very cool! Does the job exactly how I'd hope. I don't see why we wouldn't want to allow this!

I've resolved the merge conflict so we can put this on current main branch - I hope I did it right.

Copy link
Member

@chaoran-chen chaoran-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well!

@theosanderson theosanderson marked this pull request as draft May 30, 2024 18:05
@theosanderson theosanderson added the format_me Triggers github_actions to format website code on PR label Jun 18, 2024
@theosanderson theosanderson marked this pull request as ready for review June 18, 2024 20:02
@theosanderson theosanderson merged commit 85d71e8 into main Jun 19, 2024
12 checks passed
@theosanderson theosanderson deleted the customize-columns branch June 19, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
format_me Triggers github_actions to format website code on PR preview Triggers a deployment to argocd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: Search Interface Main Panel
3 participants