fix(ci): exit E2E step with proper exit code #2169
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reported by @theosanderson in https://loculus.slack.com/archives/C05G172HL6L/p1718741891080839 I caused this bug when adding step summary output here: f156c6c
|
Search sequences label was removed in #1890 - as well as searchButton. These only exist in the tests leading the search tests to fail |
|
Resolved in #2188 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported by @theosanderson in https://loculus.slack.com/archives/C05G172HL6L/p1718741891080839
I caused this bug when adding step summary output here: f156c6c
E2E should fail now, and it does! So now we just need to fix the tests.