feat(website): SSR on initial load of search page #2290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theosanderson
commented
Jul 12, 2024
theosanderson
commented
Jul 12, 2024
theosanderson
changed the title
theosanderson
requested review from
chaoran-chen,
anna-parker and
corneliusroemer
|
Hi Theo! I just tested this out a bit and thanks for fixing the bug in the date picker! However, I think I found a new bug this time in the mutation search, in CCHF I am unable to add mutations, I add a mutation to the search field - it comes up in blue but when I select it it disappears - currently main does not have this issue. I don't know why this is happening - could you have a look? |
|
Thanks! Will do! |
|
Converting to draft til I've had the chance to fix the issue @anna-parker raised |
theosanderson
added
the
format_me
|
Thanks @anna-parker - the issue you identified should be fixed |
anna-parker
approved these changes
Jul 22, 2024
|
Thank you for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the hybrid approach to the search page we discussed a while back, where the site renders the search by SSR on first load and then (as currently) in the client on further changes.
The SSR improvements also include the fields in the menu being populated immediately, rather than with a delay as previously
Also resolves #2024 (page number not being in URL), also resolves #2302 (bug in date rendering in field)
preview URL: https://search-ssr.loculus.org/