Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backend, website): Use version comments field for revocations as well. #2352

Merged
merged 17 commits into from
Aug 19, 2024

Conversation

anna-parker
Copy link
Contributor

@anna-parker anna-parker commented Jul 30, 2024

resolves #2345, #640

preview URL: https://version-comments.loculus.org/

Summary

  1. Add version_comments metadata field to values.yaml -> this will show up on the details page (this is done in feat(config): Add version_comment field to be used when revising sequences. #2355) This is still working:
image
  1. Also let revocations use this field. Need to add a revocation_comments field to the revoke endpoint and also update the website where used. Then this value needs to be shown on the webpage. The webpage gets its metadata from LAPIS, which in turn gets it from the backend. LAPIS periodically queries the backend using "/get-released-data". I add the revocation_comments field here as version_comment for revocations.
  2. Test with having the webpage always add the same string when revoking - works:
image
  1. Optionally add reason on webpage:
    image
    which is then correctly added to version_comments:
image Also added on revocationentrydatatable: ![image](https://github.com/user-attachments/assets/76111ab9-7aaf-4984-9100-6b2b2a3444d4)

Screenshot

PR Checklist

  • Adapt revocation form to allow comments
  • Figure out why the website keeps getting stuck locally - I can test the backend and postgres but the webpage is stalling weirdly.
  • Fix backend tests

@anna-parker anna-parker added the preview Triggers a deployment to argocd label Jul 30, 2024
@anna-parker anna-parker changed the title Add a version comments field that can also be used by revocation. WIP: Use version comments field for revocations as well. Jul 30, 2024
@theosanderson
Copy link
Member

To my mind wherever we use this column we could call it "version comment" – I don't see that we ever need to use the naming "revocation comment" (even though it may apply to a revocation – a revocation is still a version)

@anna-parker
Copy link
Contributor Author

anna-parker commented Jul 30, 2024

Fixed: Error: org.loculus.backend.service.submission.SequenceEntriesView.revocation_comments is not in record set

@anna-parker anna-parker marked this pull request as ready for review August 16, 2024 15:40
@anna-parker anna-parker changed the title WIP: Use version comments field for revocations as well. feat(backend, website): Use version comments field for revocations as well. Aug 16, 2024
Copy link
Member

@theosanderson theosanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice

Copy link
Contributor

@fengelniederhammer fengelniederhammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO the backend is missing a test that checks that the comment can be provided and that it is visible then somewhere else.

Copy link
Contributor

@fengelniederhammer fengelniederhammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't properly check the website part, but the Kotlin part looks good to me.

@anna-parker anna-parker merged commit a9fa920 into main Aug 19, 2024
18 checks passed
@anna-parker anna-parker deleted the version_comments branch August 19, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Triggers a deployment to argocd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version comment metadata field
3 participants