-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(backend, website): Use version comments field for revocations as well. #2352
Conversation
To my mind wherever we use this column we could call it "version comment" – I don't see that we ever need to use the naming "revocation comment" (even though it may apply to a revocation – a revocation is still a version) |
Fixed: |
backend/src/main/kotlin/org/loculus/backend/model/ReleasedDataModel.kt
Outdated
Show resolved
Hide resolved
3404c51
to
4a457eb
Compare
…a fields to be visible on page.
backend/src/main/kotlin/org/loculus/backend/service/submission/SubmissionDatabaseService.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/org/loculus/backend/service/submission/SubmissionDatabaseService.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO the backend is missing a test that checks that the comment can be provided and that it is visible then somewhere else.
...end/src/test/kotlin/org/loculus/backend/controller/submission/GetReleasedDataEndpointTest.kt
Show resolved
Hide resolved
backend/src/main/kotlin/org/loculus/backend/service/submission/SubmissionDatabaseService.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't properly check the website part, but the Kotlin part looks good to me.
resolves #2345, #640
preview URL: https://version-comments.loculus.org/
Summary
which is then correctly added to version_comments:
Screenshot
PR Checklist