Ingest add revocation comment

[anna-parker]

resolves #

preview URL: https://ingest-add-revocation-com.loculus.org/

Summary

Add description of why sequence has been revoked if revoked due to grouping changes

Screenshot

PR Checklist

• Use test data to confirm revocation commands work and add revocation details:

[anna-parker]

It would be nice to merge this before #2651

[theosanderson]

Looks good to me in terms of readability,etc.! Thanks! In terms of being confident it works:

(A) I presume you have tested it out in some way?
(B) At some point pretty soon we should add code tests for all of this - but it seems mean to do that in this PR specifically :)

[corneliusroemer]

How is regroup defined? We could in principle not revoke If the change is simply addition of a new segment to an existing segment.

Have you tested revoke with something like: run ingest with sorted authors, then ingest with unsorted authors. That should show some revokes.

[anna-parker]

How is regroup defined?

The functions were added with ingest tests in #2372.

I presume you have tested it out in some way?

I have only tested with the test examples (and some modifications of the test examples) in the ingest tests/test_data_cchf folder. #2651 seems like a good test on actual data.

We could in principle not revoke If the change is simply addition of a new segment to an existing segment.

At the moment revoke_and_regroup will always revoke the old group and create a new group. I realized handling different cases gets very complicated quickly and as this is such an edge case anyways I didn't think it made sense to go into details yet. That is also why I made revoke_and_regroup only run with manual approval. We can look into the cases and handle them differently if we would like to.